py-scrypt is a Python binding for the scrypt library and needed for installing steem-python. However, the package is outdated and did not use the newest version of scrypt. The second problem is that no wheels for python 3.6 are created. I decided to fix py-scrypt by updating scrypt to 1.2.1 and add wheels for python 3.6. All tests from py-scrypt are passed and the wheels can now be downloaded from: https://github.com/holgern/py-scrypt/releases/tag/v0.8.2. The downloaded wheel can then be installed by:
pip install scrypt-0.8.2-cp36-cp36m-win_amd64.whl
Bug Fixes
- py-scrypt 0.8.0 uses the old scrypt 1.2.0 and there was not updated since 2016. There are 17 open issues.
- py-scrypt builds no wheel for python 3.6 for windows.
- I cloned py-scrypt from https://bitbucket.org/mhallin/py-scrypt/ and uploaded my changes to github
New Features
- Newest scrypt 1.2.1 used
- Wheel for python 3.6 for Windows are build and can be downloaded here
- I asked the original author for permission to upload the new created wheels to https://pypi.python.org/pypi/scrypt
- travis build added
Next steps
- When I recieve permission, I will upload my version 0.8.2 to pypi.
- When I do not recieve an answer, should I upload 0.8.2 under a new Name to pypi? This has to be discussed now.
- I will try to add py-scrypt to conda-forge
Posted on Utopian.io - Rewarding Open Source Contributors
I hope you get an answer & your fix gets implemented, that would be the best scenario
Your contribution cannot be approved because it does not follow the Utopian Rules.
I can see that you only have updated the script to the newer version and added a Travis Build which is too small a contribution if we compare it with others. Since you saying that there are quite a bug fixes, what you can do it to fork the original repo and add it as a Pull Request, if the pull request is merged we can accept it as a Valid Contribution.
You can contact us on Discord.
[utopian-moderator]