Hi !
This one will be relatively short, remember how I wrote a new operation to update proposals and updated the way proposal fees were calculated ? Well I didn't write unit tests (although I tested them extensively) at the time.
This is now done:
https://gitlab.syncad.com/hive/hive/-/merge_requests/52
this was part of this issue: https://gitlab.syncad.com/hive/hive/-/issues/51
The idea behind unit tests is mostly to prevent regressions, regressions happens when a new features somehow affect another feature. By running unit tests we can tell if things are behaving correctly (this is not a silver bullet though, it's one of the many ways of testing software).
If you want to learn more about unit tests: http://softwaretestingfundamentals.com/unit-testing/
And while doing those tests I noticed a "bug" in the original proposal implementation and filed an issue, I will tackle it later on: https://gitlab.syncad.com/hive/hive/-/issues/53
It's not really a bug, it's more of an edge case and it doesn't really have any serious consequences. But it should be handled before someone actually runs into that edge case
It's nice when you find obscure edge case bugs before they become a problem.
It could only be a matter of a few changes elsewhere and then it's no longer and edge case bug and instead its a pain in the arse.
Thanks for your work.
Had to downvote cause the post is over rewarded, no hard feelings!
That's perfectly understandable, thank you for working towards proof of brain :)
nice... Sir
Great
Simply wonderful
Awesome
Congratulations @howo! You have completed the following achievement on the Hive blockchain and have been rewarded with new badge(s) :
You can view your badges on your board And compare to others on the Ranking
If you no longer want to receive notifications, reply to this comment with the word
STOPSupport the HiveBuzz project. Vote for our proposal!
Simple and effective.