Thanks for the answers. I would love to do more PR's, but lately, time to reply is already a luxury. I will keep giving this a watch and provide any feedback, and if I find anyone keep on helping out, will point he/she in your direction.
I have noticed also you guys used python 3.13 (which is very recent). Would be nice to support older versions, but its not a problem if not. As in a few months, all pythons everywhere will be supporting 3.13 anyhow.
Just a thought.
I appreciate the feedback just as much as a pull requests.
It just happens to be the version i'm using, there is no 3.13 specific features being used, should work without problems back several versions (i've tested 3.11, and 3.12)
Not for those... but for 3.10 there is. Close enough though =)
Unfortunately, Ubuntu 22 is still behind. Plus a couple of other Linux distros... either way this would need to be changed on the repo.
$ cat src/engine_bench/__init__.py """Nectar-bench package for benchmarking hive-engine nodes using nectarengine.""" import sys __version__ = "0.2.0" # Check Python version if sys.version_info < (3, 13): print("Error: engine-bench requires Python 3.13 or higher") sys.exit(1)I can install 3.X whatever but just thinking on people that are just using Linux distributed versions.
I am pushing because I see good stuff... not because I dislike stuff. 😎😍
good catch, i'll destroy that section in both benchmarks
Thanks!