RE: OneLoveDTube IPFS Uploader v0.8.4: Keychain auth support, updated homepage and more!

[justyy]

Thank you for your contribution @techcoderx !

1. It is better to use === instead of == (!== instead of !=)in JS and ==true seems redudant.
2. Some parts of the JS code end with a semicolon but some do not.
3. some vars could be replaced by either const or let.
4. The messages you are alert-ing in the JS code could be extracted in a JSON file so that you can internationalize them later.
5. Unit Tests missing in the project - you could use mocha/chai or other testing frameworks and set up the CI using travis-ci.com

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Chat with us on Discord.

[utopian-moderator]

Comments

[utopian-io]

Thank you for your review, @justyy! Keep up the good work!

[d00k13]

Right on @justyy thank you for the feedback 💪

Posted using Partiko iOS