You are viewing a single comment's thread from:

RE: Alphabet Detection and Frequency Analysis of Unicode Ranges with PHP

in #utopian-io6 years ago

Thanks for the contribution, @programarivm! It's always cool to read about people creating something for a specific need that they couldn't find elsewhere!

Some thoughts about the pull request:

  • Even though there is little code, you could still add some comments (like function declarations, for example).
  • Commit messages could be better - this is a good reference.

I look forward to seeing more of your contributions!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @amosbastian!

So far this week you've reviewed 10 contributions. Keep up the good work!

Thanks for the review @amosbastian.

In regards to commenting the code, I believe it is okay not to write comments as long as the code is simple enough, self-explanatory and the names of variables, methods, constants and so on, are meaningful.

Anyway I am reviewing the code already, thank you.