You are viewing a single comment's thread from:

RE: steemrewarding.com - curation performance is shown and other improvements

in #utopian-io7 years ago (edited)

Thanks for your advice! Will do that way next time though @holger80's style looks very cool :) By the way, what's the min num of commits for utopian dev? I try to gather more, but sometimes, PO doesn't merge often. Since I'm external contributor, this may lead to just one commit for a 14 day window.

While I expected that if latest one is within 14 day, even passed one should be fine, but it seemed not based on the review for my submission.

Sort:  

By the way, what's the min num of commits for utopian dev?

There is no minimum (apart from 1 I guess, lol). As for the time limit rule: if it's a pull request it's within 14 days of it being merged. If commits aren't part of a pull request, then it's 14 days from them being committed.

Thanks a lot! I have a clarifying question though. I'm not a PO. Is it still okay to submit PR that hasn't been merged? If this isn't allowed, I may end up with one commit in some cases due to infrequent/irregular merging by PO.

Sorry for the late reply, I somehow completely missed this! As for your question, you are correct in saying that a PR must have been merged, so unfortunately this means that in the case of irregular merging by a PO there could be a problem. However, we try to use common sense and be a bit lenient towards stuff like this, so it's always worth asking us beforehand if you have any doubts!

No problem and thanks a lot for your answer. Yes, it should be lenient :) Thanks!