Hi there @holger80!
The client library looks great. Library looks like a read-only library at the moment. It's nice that you plan to add support broadcasting like transferring, issueing tokens, etc.
I have a couple of minor code review comments :)
Method names don't follow the PEP8 conventions. We have get_history, and getLatestBlockInfo. I would prefer following PEP8's convention.
Regarding findOne, I would expect a single object here. If there are multiple objects returns, an exception might be raised. (Ex: Django ORM's
objects.getworks like that.)It would be clear to check response status with
response.status_code != 200instead ofstr(response) != '<Response [200]>'.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thanks for fast review and the good suggestions.
Yes, broadcasting is on my list for the next update.
Thank you for your review, @emrebeyler! Keep up the good work!