RE: Pywit Version 1.1.1 & Utopian-io Submission

[emrebeyler]

Hi there,

Pywit looks good.

Since you didn't share the original announcement post on Utopian, I will review the project as a whole instead of the recent updates.

• It seems pywit lacks support for witness_set_properties operation. It would be good if we have support for that. It's possible to broadcast witness updates (on witness params) by witnes' signing key. Which is useful on many cases.

• There are a couple of undefined self calls.^{1, 2} causes errors on some calls. (See an example log)

• Regarding testing user inputs, you can have a look to one of my projects' testing file: https://github.com/emre/storm/blob/master/tests.py#L82. run_cmd and test_list_command functions may give a clue.

---

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Comments

[petertag]

Great, thanks for the errors you pointed out! I saw your comment on bobinson's post about pipfiles, I was wondering the reason you're not a big fan, since I don't have an opinion one way or the other yet. I had setup.py because it was easy to setup and figure out, basically for a quickstart, wasn't sure what the differences were when I was choosing one to use.

[petertag]

Hey again, do you have any docs on the witness_set_properties using the witness's public signing key? So far I don't think beempy supports it, but I could look into setting up a workaround in pywit. Or is it just with the private signing key that you mean?

[emrebeyler]

You can sign with the private signing key. (witness key)

Check here for an example for witness_set_properties.

[utopian-io]

Thank you for your review, @emrebeyler! Keep up the good work!