RE: POCKET-JS, the NodeJS POCKET confirmer

[gregory.latinier]

It's nice to revive project and not let them decay!
Let's hope it will be used :p

Let's go for the review:

• Since the account doesn't have much Steems on it I'll write it: https://github.com/quochuy/pocketjs/commit/aefd1a49738bf72c926201b7da04e735ec25e42d#diff-e22b50e740e102c8de5e858dbcd7753dL6 => Never ever post your private keep! Github archives everything :p. You better change it now :D

• https://github.com/quochuy/pocketjs/blob/master/bot/confirmer.js#L56 => Any particular reason for not using && since you don't have any elses ?

• https://github.com/quochuy/pocketjs/tree/master/bot/test => You have a lot of tests and there are not useless this is awesome !

• https://github.com/quochuy/pocketjs/commit/92f21722b6b30d12fdff588407789f55cf3a1a66 => Try to do a better job about your commits ha ha, can't remember... :-P, misc this is not serious, or having Validator or Add config twice. You can be more precise. Good comments are free!

• It's nice to add a docker config. Really cool.

This a great job overall!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Comments

[quochuy]

@gregory.latinier ARG! I thought I filtered out that from the history already! Thanks for letting me know!
And thanks for the very thorough review!

[symonp]

That was fast. Congrats @quochuy <3

[quochuy]

To answer the other questions:

• password changed, thanks again
• && instead of elses is because I did a straight port from Python to JS https://github.com/biophil/pocket/blob/master/blockchain_reader.py#L135 and I haven't yet gone thru code optimization and rewrite as the primary goal is to get the JS version up and running with the same logic. So keeping things as close as possible to the original makes it easier if I spot a behavior that is different from the Python version.
• The tests were very useful as I get to change code here and there as I go, this allowed me to make sure that I didn't break anything with the new changes and refactor.
• hahaha, I'm often working on a train and then forget to commit as I rush down, three days later... can't remember things. Advice taken :-)
• I do almost everything with Docker as it makes it so much easier to deploy or migrate

Thanks again @gregory.latinier