You are viewing a single comment's thread from:

RE: SteemRadar.js - A New Major Release, New Features, Update 1.0.0

in #utopian-io5 years ago

Thank you for your contribution!

  1. You may add the unit tests part of the CI using travers-ci i.e. showing a green tag on the project page along with others.
  2. The tests you added previously may seem weak, which doesn't test your latest changes.
  3. Lack of Sample code to use your aliases
  4. Have you considered statusCode of 301 and 302 redirection? which might not mean Request Failed
  5. You might want to extract the for (const trx of transactions) { and use a filter call back to remove the duplication code in getPosts, getComments.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thanks for the review.

  • The blockchain aliases pattern mostly the same as the one in README.md
    Also parameters documented here
  • statusCode 301 and 302 redirects are not expected from that API as I know but I will consider it.
  • The rest will be taken into account for the next update.

Thank you for your review, @justyy! Keep up the good work!