You are viewing a single comment's thread from:

RE: Product API implementation into the PHP Client for Makerlog

in #utopian-io5 years ago

Thank you for your contribution. You probably want to take a look at Rest API Design.

  1. this line seems duplicate.
  2. Your getProductData has been called in its many APIs to get the sub-field which may be cached.
  3. The getData and many other APIs has a long chain in getting its field data, which may throw exception e.g. null pointer. The try-catch will hide the errors and prevent early identification of the risks - which is generally a bad idea.
  4. When performing addUserToTheTeam, have you thought about multiple requests i.e. race conditions?

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!