RE: QUIQQER Core and QUIQQER Log Update - Chaos issues

[justyy]

Thank you for your contribution.

1. you can write $errorlevel |= E_WARNING
2. you may want to cache / shorten the channel self::getPackage()->getConfig(), does getPackage() return null sometimes?
3. you might consider using let or const to replace var.
4. have you considered using async/await to make your promises look nicer?
5. It is generally not a good idea to comment out the code. instead, code not needed should be just removed.
6. $Parent->getAttribute('order_type') can be extracted as a variable.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Chat with us on Discord.

[utopian-moderator]

Comments

[dehenne]

1. O.O I never know that. thank you!
2. nope, if, then you have a file system error and bigger problems :D
3. IE 11 dependency
4. IE 11 dependency
5. I know, but I want more people to look at it next week.
6. yes

Thanks for looking over it. Really. That helps a lot

[utopian-io]

Thank you for your review, @justyy! Keep up the good work!