Related Informations
- Repository: https://github.com/ttdyce/NHentaiViewer
- Project Name: NHViwer/ NHentaiViewer
- My Submitted Issue: https://github.com/ttdyce/NHentaiViewer/issues/7
- My GitHub Account: here
Describe the bug
When I tried to click on the "history" option after deleting history from the collection option, then the app crashed.
To Reproduce
Steps to reproduce the behavior:
- Open the app.
- Go to the main menu of the app and click on the "Collection".
- You will see two tabs. Tap and hold the "history" and click on the delete icon to delete it.
- Now once again go to the app's main menu and try to go to the "History" option and see an error.
Expected behavior
I expected that I could click on history after deleting it from the collection menu without getting any trouble
Information:
- Device: Samsung A5
- OS: Android 6.0.1
- Version 1.0.3
07-27 12:48:29.182 5007 5007 D AndroidRuntime: Shutting down VM
07-27 12:48:29.182 5007 5007 E AndroidRuntime: FATAL EXCEPTION: main
07-27 12:48:29.182 5007 5007 E AndroidRuntime: Process: personal.ttd.nhviewer, PID: 5007
07-27 12:48:29.182 5007 5007 E AndroidRuntime: java.lang.NullPointerException: name == null
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at java.io.File.<init>(File.java:146)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at java.io.File.<init>(File.java:118)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Model.Saver.JSONSaver.getFile(JSONSaver.java:411)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Model.Saver.JSONSaver.getJSONArr(JSONSaver.java:269)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Model.Saver.JSONSaver.getCollection(JSONSaver.java:116)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Model.Saver.JSONSaver.getHistory(JSONSaver.java:68)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Model.comic.ComicMaker.getComicListHistory(ComicMaker.java:31)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Controller.fragment.HistoryFragment.setList(HistoryFragment.java:24)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at personal.ttd.nhviewer.Controller.fragment.base.BaseListFragment.onViewCreated(BaseListFragment.java:95)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1471)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1784)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1852)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:802)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2625)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2411)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2366)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2273)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:733)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:739)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.os.Looper.loop(Looper.java:148)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7325)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
07-27 12:48:29.182 5007 5007 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
Hello, @sagorahmed! Thank you for your contribution. Tried the old version and it did crash. Good to see that the PO already got the issue fixed. As always, thank you for following up with the PO and providing a log to help decipher the issue. Well done.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @knowledges! Keep up the good work!
Hey, @sagorahmed!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!
Congratulations @sagorahmed! You received a personal award!
You can view your badges on your Steem Board and compare to others on the Steem Ranking
Vote for @Steemitboard as a witness to get one more award and increased upvotes!