RE: Introducing Steeve Vote Beneficiaries

[espoem]

The line you refer to precedes the pay_curators function.

https://github.com/steemit/steem/blob/master/libraries/chain/database.cpp#L1789 this code splits the rewards into authors and curations.

But then https://github.com/steemit/steem/blob/master/libraries/chain/database.cpp#L1791 is there to split curations rewards amongst the curators. At this point, you have ca 75% (won't claim exact numbers) in authors rewards. However, pay_curators returns 0 (= curation_remainder) and max rewards (= curation_tokens) will be 0 too.

https://github.com/steemit/steem/blob/master/libraries/chain/database.cpp#L1794
https://github.com/steemit/steem/blob/master/libraries/chain/database.cpp#L1797

In both cases, zero is added and authors rewards stay at 75%. Then the beneficiaries are calculated, which may decrease authors rewards even more.

Comments

[hr1]

At this point, you have ca 75% (won't claim exact numbers) in authors rewards.

Where did you get the 75%?

On line 1788 you have full rewards in reward_tokens, right?

_{Posted using Steeve, an AI-powered Steem interface}

[espoem]

As I said I am not claiming that the numbers are right. However, the rewards are split in 3:1 ratio, therefore authors rewards make 75% of total rewards in the end.

Yes, it appears so that in rewards_tokens the full rewards are included.

Edit: https://github.com/steemit/steem/blob/master/libraries/chain/database.cpp#L4897 Curation rewards ratio.

[hr1]

I think you're right :(

get_curation_rewards_percent takes comment as a parameter, but doesn't do anything with it and returns always 25%.

And then in pay_curators there is this piece of code:

if( !c.allow_curation_rewards )
      {
         unclaimed_rewards = 0;
         max_rewards = 0;
      }

Which (imo without a reason) resets all curation rewards to 0. I opened an issue to find out if it's a feature or a bug.

Thanks a lot for pointing that out! We will have to update the way how steeve vote beneficiaries are implemented, but the general idea is still valid.

_{Posted using Steeve, an AI-powered Steem interface}

[sircork]

bump to follow this thread when the results come back from the newest test. hope you will provide your findings here @hr1, thanks.

[hr1]

I just did.

_{Posted using Steeve, an AI-powered Steem interface}

[hr1]

I have the results of the test. You were right, disabled curation rewards returns them into the reward pool.

I created 2 test comments and upvoted them right after. The first one had disabled curation rewards, the second one allowed. There is no difference between their author rewards (except the few satoshis due to the decreased voting power on second comment).

curation	author rewards	curation rewards	link
disabled	0.098 STEEM and 0.098 SP	0	https://steemd.com/b/28565512
allowed	0.094 STEEM and 0.095 SP	0	https://steemd.com/b/28566233

_{Posted using Steeve, an AI-powered Steem interface}