RE: Contribution - Actifits NodeJS voting bot and token calculator

[gregory.latinier]

You did a great job with this task request. It really cool to take the time to improve an open source project and actifits is worth it in my opinion.

Let's go for the review:

• Why the gitignore is so huge? It seems a little bit of an overkill

• Useless comments war mouahaha, are those really necessary? You got a few of these.
  

but this one is good!

• https://github.com/mcfarhat/actifit-bot/pull/1/files#diff-0364f57fbff2fabbe941ed20c328ef1aR38 => Why do you keep this?

• You're using a lot of console.log but you've implemented a log util why not use it? Either log what's useful or remove console.log that are here for debug purposes.

• You're mixin const var and let notation. You should drop the var

• Sometimes you're using {} sometime not with ifs and elses which leads to things like that

if(XXX) {
} else if()
XXX
else {
XXX
XXX
}

I think it's weird to read

• You've got useless padding

• Using ++ is a bad practice => https://eslint.org/docs/rules/no-plusplus

• You're mixin function(){} with () => {} arrow notation

• Sometimes you use == instead of ===

• You're mixing camelCase and snakeCase notation
  

• You've left dead code :p feeling sentimental?

• You've got indentation issues

• From the few previous issues I think you should add prettier and/or eslint to have a homogeneous code.

• Nicely done on the getVotingPower function implementation you didn't forgot about the last vote time!

• Yeah you use the Async syntaxe steem.api.getRebloggedByAsync! +1

• I see that you've got some knowledge of mongodb await db.collection('token_transactions').aggregate +1 too :p

In overall this is a good but you're using old javascript notations with new ones (ES6, ...) if think using eslint would really benefit you.

Keep up the work, congrats!

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.

---

Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Comments

[utopian-io]

Hey @gregory.latinier
Here's a tip for your valuable feedback! @Utopian-io loves and incentivises informative comments.

Contributing on Utopian
Learn how to contribute on our website.

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

[cryptouru]

Thanks @gregory.latinier you're the man! Your review is awesome and very well thought. Even though it's kinda harsh for me I really appreciate you took the time to write it and I will use it to learn and improve.

As your review came with some questions I will try to answer some to my best. Though many of the cases are errors I made with no particular explanation.

Why the gitignore is so huge? It seems a little bit of an overkill

I used some boilerplate .gitignore which may have been quite an over kill.

You're using a lot of console.log but you've implemented a log util why not use it? Either log what's useful or remove console.log that are here for debug purposes.

I kinda like the mix of both of them. I appreciate the additional information when I manually execute but aknowledge there is no need to log it.

In overall this is a good but you're using old javascript notations with new ones (ES6, ...) if think using eslint would really benefit you.

Totally! I 'm moving into ES6 yet the original codebase wasn't so. So it sorta ended up very messy :/

Eslint will surely help! I really apreciate this feedback. Thanks againt.

Cheers :)