Related Informations
- Repository: https://github.com/warren-bank/Android-WebCast
- Project Name: WebCast
- My Submitted Issue: here
- My GitHub Account: here
- Fixed cummit: here
Expected behavior
I expected that the app would warn or block me when I tried to bookmark a blank page.
Actual behavior
The app crashed when I bookmarked a blank page. After that this crash occurring every time whenever I am trying to open the app.
How to reproduce
Here is every possible detail to reproduce the bug.
1. Open the app
2. Click on the bookmark button at the top of your screen.
3. Notice the crash. After that, whenever you will try to open this app, you have to face the crash. (You can make it workable again after deleting the app data)
- App version: 04.07.01
- Operating system: Android 6.0.1
Recording Of The Bug
LogCat
05-21 14:35:14.108 8984 8984 E AndroidRuntime: FATAL EXCEPTION: main
05-21 14:35:14.108 8984 8984 E AndroidRuntime: Process: com.github.warren_bank.webcast, PID: 8984
05-21 14:35:14.108 8984 8984 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.github.warren_bank.webcast.webview.BrowserActivity$DrawerListItem.equal(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.github.warren_bank.webcast.webview.BrowserActivity$DrawerListItem.find(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.github.warren_bank.webcast.webview.BrowserActivity$DrawerListItem.contains(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.github.warren_bank.webcast.webview.BrowserActivity.onCreateOptionsMenu(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at android.app.Activity.onCreatePanelMenu(Activity.java:3142)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.f.a.e.onCreatePanelMenu(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.appcompat.view.i.onCreatePanelMenu(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.appcompat.app.g$d.onCreatePanelMenu(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.appcompat.view.i.onCreatePanelMenu(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.appcompat.app.j.i(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at androidx.appcompat.app.j$1.run(Unknown Source)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:739)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at android.os.Looper.loop(Looper.java:148)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7325)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
05-21 14:35:14.108 8984 8984 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
Hi @sagorahmed, thanks for making this report.
I see the PO already fixed this. It is a simple case of validation. Blank pages or in other words null values should not be allowed into the bookmark function. A simple fix would be to validate that the pages to be bookmarked are not blank before running the bookmark function.
I think this is what he did. Thanks for catching the error. It's a good find with a simple fix. I like how you engaged the PO in the comment section, good job
PS:
In your expected behavior you said you expected the "app would warn or block me". It shouldn't block you. Instead, an error message should be shown to the user, something like "You cannot bookmark a blank page". I believe that will be more descriptive.
I look forward to your future reports.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Hi @sagorahmed!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @sagorahmed!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!