My new contributions to the Hive Condenser and Wallet apps.

in HiveDevs3 years ago

Context

I have been involved (voluntarily) with the development of the Condenser & Wallet apps (that are powering https://hive.blog and https://wallet.hive.blog) for quite a while now. There are other great frontends to Hive out there such as https://peakd.com and https://ecency.com but I have always been more or less faithful with the Condenser.

This is a regular report on my new contributions. Some of the new work below might still be in test and not yet deployed.

Completing React v16 upgrade

This project took a bit of time to complete. Because we have upgraded the core library of the Condenser, we had to thoroughly test the app before releasing it. It's finally done and out.

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/231

Condenser code clean-up

Now that the React v16 upgrade has completed, I decided to take on another large task I started 8 months ago. The goal was to get all JS and JSX files to pass EsLint. After getting everything fixed up, I was excited but then realised that the project was misconfigured and JSX files were never tested against and there was a huge amount of them. So I did what I could and fixed up the most popular files and left the rest to be done every time we start touching a new file. Thanks to @engrave for testing these and updating the GitLab pipeline. Any new commits to the code base will now be rejected if it fails EsLint or Unit Test.

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/197/commits

Fix Storybook

As part of the cleanup, I've also fixed Storybook. It's a tool that allows you to render each component of your project in isolation.

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/278

Fix vote breakdown display

The vote breakdown display was not ideal when the post value is zero. So instead of showing vote values of $0, I just showed the voters and if it's a downvote.

Vote breakdown

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/264/diffs

Removal of Google ads code

Since we are not using this anymore, removing it will reduce the code base.

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/276

Adding a cache buster to avatar URLs

Hive user's avatar URL is an alias that redirects to the actual image URL. That redirection is cached and is sometimes creating confusion as it does not reflect the new avatar when someone uploads a new image. We agreed on adding a cache buster to avatar URLs. That cache buster is generated once per session so we are still taking advantage of the cache during the session.

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/269

Embedded players

I've modified the embedded player code to better handle video player aspect ratios. I've also added support for Instagram and TikTok embedded players.
Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/275/diffs

Fix page crash when community ID does not exist

Merge request: https://gitlab.syncad.com/hive/condenser/-/merge_requests/273


Vote for my witness
Support @quochuy Witness.jpg
On Hive, Witnesses are playing the important role of providing a performant and safe network for all of us. You have the power to choose 30 trusty witnesses to package transactions and sign the blocks that will go in the Hive blockchain. Vote for me via HiveSigner to support my work for the community.

Sort:  

Downvote is very bad thing on this platform. If we don't like any post, we can ignore that post. I am watching up vote and down vote war is going on this platform.

Downvote is a tool. It can be used for good too, such as downvoting posts that are spams, phishing, plagiarising etc... as any tool, it can also be used for bad.

If any post going against community standards then users can report post. Then Hivewatcher can take action on that post. But with downvote tool, most of users are doing target downvote. If one user give value upvote to any post. Then user with big HP do downvote on that post and say that post does not deserve any value upvote. You know that big HP users 1% down vote is also very powerful. They can do anything. If user will decide that post is wrong..Then what is job for hivewatchers !

Without downvote what can Hivewatchers do against a post?

They can remove, hide any post which is going to against community standards. But post must be against community standards. This decision can not take without honest review on the post. They can ban user's post and comments for 1 day, 3 days, 7 days, 30 days, Like fb ban users and remove many posts even that one also who got majority love reaction. I don't know hive team can do this or will want to do this.

This is not possible. The blockchain cannot be controlled by a specific group of people.

But specific group of people can decide which post desreve downvote. One user is giving up vote and another user is down vote. Upvote user is saying that is good post. Down vote user is saying this is shit post. So users opinions can not be same. But in this up vote and down vote war, user with big HP will win always.

One more question.
What is difference between ban and blacklist ? When hive team put any user into blacklist then user get downvotes from specific group of people . It means specific group of people have banned to user and now user can not get paid from their posts and comments. I am watching a blacklisted user's comment on your post. That comment is hide due to low rating. Indirectly it means that user is banned !

Hive.Blog is not Hive. Hive.Blog is just a frontend (website) allowing you to access content stored in the Hive blockchain. The Hive blockchain itself is a speech free platform. You cannot hide/remove content from the blockchain, Hive.Blog is only preventing it from being displayed on its frontend.

Using a block explorer, you can access and view any hidden posts or comment, your hidden comment for example can be viewed here:

If you are a developer or know a developer, you could even create your own frontend that does not hide anything.

So while you could say some Hive frontends are not fully free speech, Hive itself is.

Unfortunately, this is crucial for the hive platform

 3 years ago  Reveal Comment

I consider what you say, I think it's phenomenal.

Still, there are users who have taken it upon themselves to damage a lot of things, and have done things that deserve them, so downvotes can counteract their moves a bit.

Anyway, I would like to think that there is some way to remove those accounts, although that would go against the decentralization policy.

But surely, there will be a way to solve that.

Translated with www.DeepL.com/Translator (free version)

Hi, love youre effort as allwqys....
Guestion, is it possible to recive notification when someone adds you as benefactor for a post reward? That would be legend.
!BEER
Greez
!invest_vote

I’d love that too. @blocktrades can we add this to Hivemind?

Yes, it should be possible to add a feature like that to hivemind, but I don't have anyone free to work on something like that right now. But @howo is looking at doing some work on hivemind, so maybe he will consider adding it to his list (although I think his proposed community-related work is higher priority).

That sounds doable, I'll make an issue and add it to my todo list :)

Amazing!
Thank you 🍻
!BEER 🍻

Thank you, this is epic!
!BEER 🍻

This is why I love hive!
What a turn out!
Thank you for the effort!
!BEER 🍻

Good to know there is clean up effort! Thanks!

Nice work. It will be nice if the condenser can show the voting power and current vote value when someone is clicking on the vote button. It will be a very good feature to have.

image.png

It’s already planned. Just haven’t had time to get to it yet.

hive.blog not working right now!! What did you do!!!!???

What's not working?

it´s all right now, the page wasn't loading.

It can happen after a release, some caches take time to refresh

I have always wanted to ask, Why isn't there a "post delete tool" because some information or post lose relevance after a while or they become not useful. I understand the downvote tool but this not able to delete a wrong post or mistaken post is what I don't understand.

Because the posts are stored in a block on the blockchain and once on the chain it cannot be deleted or modified. When you edit a post the original post is still there. Even if you edit and make the post empty the original post is still there and it’s possible to retrieve it.

It’s also the strength of a blockchain. If you say something in a post or comment, it’s there forever, you cannot later say that you didn’t say it.

Now I understand, That explains transparency and visibility in the blockchain. Thanks.

But On the other Hand, There is a delete Option for comments.

It’s not really deleted. Also you can only use it if the comment has not received any replies or votes. If memory serves you can also delete a post if not votes or comments have been received. But again, the original post or comment is still on the blockchain

Thanks For this informations! Keep the good work sir!

Wow, what a great job. I believed in the process of doing this, it took you time but you never gave up. Thanks for that bro.

@sandymeyer denkt du hast ein Vote durch @investinthefutur verdient!
@sandymeyer thinks you have earned a vote of @investinthefutur !

Nice work, thanks for what you do. What do you think of the voting value display on Hive.blog?

Already asked above 😊

Oh!! That’s cool, I admire what you do, am about to vote you as witness.

Congratulations @quochuy! Your post has been a top performer on the Hive blockchain and you have been rewarded with the following badge:

Post with the highest payout of the day.

You can view your badges on your board and compare yourself to others in the Ranking
If you no longer want to receive notifications, reply to this comment with the word STOP

Check out the last post from @hivebuzz:

Hive Power Up Day - October 1st 2021 - Hive Power Delegation
Hive Power Up Month - Feedback from Day 25

Good Job.
Love with HIVE.

Great job and keep up your good work in the progress of hive community

Thanks a lot for what you are doing to our community.

Although I cannot understand many of your language as these are related to the cooling but it is very clear to me that you have done a great job for the betterment of the platform. thank you very much for such a contribution with your coding skill.